Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compressed flags #5403

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Compressed flags #5403

merged 2 commits into from
Jul 7, 2023

Conversation

iulianpascalau
Copy link
Contributor

Reasoning behind the pull request

  • compressed flags after mainnet release

Proposed changes

  • compressed flags

Testing procedure

  • standard system test

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@iulianpascalau iulianpascalau added the ignore-for-release-notes Do not include item in release notes label Jul 6, 2023
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.04 🎉

Comparison is base (5a06a1f) 77.57% compared to head (2163257) 77.61%.

❗ Current head 2163257 differs from pull request most recent head 6fb4231. Consider uploading reports for the commit 6fb4231 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5403      +/-   ##
==========================================
+ Coverage   77.57%   77.61%   +0.04%     
==========================================
  Files         654      654              
  Lines       86044    86044              
==========================================
+ Hits        66745    66782      +37     
+ Misses      14092    14057      -35     
+ Partials     5207     5205       -2     

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed.
@@ Log scanner @@

v1.5.8-dev-config

================================================================================

  • Known Warnings 10
  • New Warnings 2
  • Known Errors 0
  • New Errors 0
  • Panics 0
    ================================================================================
  • block hash does not match 7742
  • wrong nonce in block 2815
  • miniblocks does not match 0
  • num miniblocks does not match 0
  • miniblock hash does not match 0
  • block bodies does not match 0
  • receipts hash missmatch 0
    ================================================================================

@iulianpascalau iulianpascalau merged commit 2409c04 into master Jul 7, 2023
@iulianpascalau iulianpascalau deleted the v1.5.8-dev-config branch July 7, 2023 08:22
@iulianpascalau iulianpascalau restored the v1.5.8-dev-config branch July 7, 2023 08:22
@iulianpascalau iulianpascalau deleted the v1.5.8-dev-config branch May 13, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes Do not include item in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants