Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New p2p libs #5327

Merged
merged 35 commits into from
Jul 7, 2023
Merged

New p2p libs #5327

merged 35 commits into from
Jul 7, 2023

Conversation

iulianpascalau
Copy link
Contributor

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@iulianpascalau iulianpascalau changed the title Test p2p options New p2p libs Jun 8, 2023
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.03 🎉

Comparison is base (5a06a1f) 77.57% compared to head (bd33f4b) 77.60%.

❗ Current head bd33f4b differs from pull request most recent head bc1299f. Consider uploading reports for the commit bc1299f to get more accurate results

Additional details and impacted files
@@                       Coverage Diff                       @@
##           feat/go-v1.20.5-integration    #5327      +/-   ##
===============================================================
+ Coverage                        77.57%   77.60%   +0.03%     
===============================================================
  Files                              654      654              
  Lines                            86044    86042       -2     
===============================================================
+ Hits                             66745    66776      +31     
+ Misses                           14092    14059      -33     
  Partials                          5207     5207              
Impacted Files Coverage Δ
factory/network/networkComponents.go 74.60% <ø> (-0.40%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@iulianpascalau iulianpascalau marked this pull request as ready for review July 4, 2023 13:28
@raduchis raduchis self-requested a review July 4, 2023 13:29
raduchis
raduchis previously approved these changes Jul 4, 2023
@iulianpascalau iulianpascalau changed the base branch from master to feat/go-v1.20.5-integration July 7, 2023 07:08
@iulianpascalau iulianpascalau dismissed raduchis’s stale review July 7, 2023 07:08

The base branch was changed.

@iulianpascalau iulianpascalau merged commit cf385e3 into feat/go-v1.20.5-integration Jul 7, 2023
@iulianpascalau iulianpascalau deleted the test-p2p-options branch July 7, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants