Fixed the indexer creation #5265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sstanculeanu
approved these changes
May 22, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## rc/v1.6.0 #5265 +/- ##
=============================================
+ Coverage 79.64% 79.69% +0.04%
=============================================
Files 688 688
Lines 88732 88733 +1
=============================================
+ Hits 70674 70717 +43
+ Misses 12888 12850 -38
+ Partials 5170 5166 -4
☔ View full report in Codecov by Sentry. |
gabi-vuls
approved these changes
May 23, 2023
There was a problem hiding this comment.
@@ Log scanner @@
fix-indexer-creation
================================================================================
- Known Warnings 6
- New Warnings 1
- Known Errors 0
- New Errors 0
- Panics 0
================================================================================ - block hash does not match 8568
- wrong nonce in block 3262
- miniblocks does not match 0
- num miniblocks does not match 0
- miniblock hash does not match 0
- block bodies does not match 0
- receipts hash missmatch 0
================================================================================ - No jailed nodes on the testnet
================================================================================
miiu96
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?