Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proper core release #5244

Merged
merged 3 commits into from
May 17, 2023
Merged

proper core release #5244

merged 3 commits into from
May 17, 2023

Conversation

bogdan-rosianu
Copy link
Contributor

Reasoning behind the pull request

  • proper core release

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@bogdan-rosianu bogdan-rosianu added the ignore-for-release-notes Do not include item in release notes label May 17, 2023
@bogdan-rosianu bogdan-rosianu self-assigned this May 17, 2023
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (f1dfadf) 79.70% compared to head (0dfb43b) 79.69%.

❗ Current head 0dfb43b differs from pull request most recent head ebf3740. Consider uploading reports for the commit ebf3740 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##           rc/v1.6.0    #5244      +/-   ##
=============================================
- Coverage      79.70%   79.69%   -0.01%     
=============================================
  Files            682      682              
  Lines          88256    88256              
=============================================
- Hits           70342    70340       -2     
- Misses         12788    12789       +1     
- Partials        5126     5127       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bogdan-rosianu bogdan-rosianu merged commit 9a551a5 into rc/v1.6.0 May 17, 2023
@bogdan-rosianu bogdan-rosianu deleted the proper-core-release-rc-v-1-6 branch May 17, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes Do not include item in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants