unit tests for state/syncer #5239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## feat/trie-sync-optimizations #5239 +/- ##
===============================================================
Coverage ? 79.08%
===============================================================
Files ? 683
Lines ? 88367
Branches ? 0
===============================================================
Hits ? 69887
Misses ? 13273
Partials ? 5207 ☔ View full report in Codecov by Sentry. |
| return tr | ||
| } | ||
|
|
||
| func TestUserAccountsSyncer_SyncerAccountDataTries(t *testing.T) { |
There was a problem hiding this comment.
Suggested change
| func TestUserAccountsSyncer_SyncerAccountDataTries(t *testing.T) { | |
| func TestUserAccountsSyncer_SyncAccountDataTries(t *testing.T) { |
| require.Equal(t, expectedErr, err) | ||
| }) | ||
|
|
||
| t.Run("should work", func(t *testing.T) { |
There was a problem hiding this comment.
few notes here in order to increase the coverage:
- missing
IsInterfaceNiltest - coverage can be increased with a test similar with
should work, but throttler.CanProcess returns false andSyncAccountDataTriesgets as param a closed context(this would lead to time is out error) - a new test with
ReadFromChanNonBlockingreturning error - perhaps a test with largeTries, to cover more of printDataTrieStatistics(not sure if doable)
There was a problem hiding this comment.
added more tests, might add for more scenarios in a later task
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestNewValidatorAccountsSyncer(t *testing.T) { |
There was a problem hiding this comment.
missing IsInterfaceNil test
sstanculeanu
approved these changes
May 15, 2023
BeniaminDrasovean
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?