pass storageMarker as argument when SyncAccounts() is called

[BeniaminDrasovean]

Reasoning behind the pull request

• When a missing trie node is found, the subtrie starting from that hash will be synced. This is triggered on SyncBlock(). However, the storage should not be marked as synced and active - not the whole trie was synced, but just a missing subtrie.

Proposed changes

• Pass storageMarker to SyncAccounts() func. This way, a disabled storage marker can be given in case the db should not be marked as synced.

Testing procedure

• Normal testing procedure with missing trie nodes.

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

• was the PR targeted to the correct branch?
• if this is a larger feature that probably needs more than one PR, is there a feat branch created?
• if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (feat/sync-missing-trie-nodes@da1e15e). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head ee04a62 differs from pull request most recent head e4cd99a. Consider uploading reports for the commit e4cd99a to get more accurate results

Additional details and impacted files

@@                       Coverage Diff                       @@
##             feat/sync-missing-trie-nodes    #5188   +/-   ##
===============================================================
  Coverage                                ?   70.65%           
===============================================================
  Files                                   ?      677           
  Lines                                   ?    88061           
  Branches                                ?        0           
===============================================================
  Hits                                    ?    62218           
  Misses                                  ?    21152           
  Partials                                ?     4691           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[iulianpascalau]

Please add here a test for nil storageMarker argument. The code can panic on L135. You need to add CheckIfNil on the StorageMarker interface. Valid for validatorAccountsSyncer.go L82.
+ unit tests

[BeniaminDrasovean]

Done.