Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add extra fields on prepare transaction #5162

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

AdoAdoAdo
Copy link
Contributor

@AdoAdoAdo AdoAdoAdo commented Apr 5, 2023

Reasoning behind the pull request

  • missing fields in the transaction response for guarded transactions

Proposed changes

  • added the missing fields

Testing procedure

  • send guarded transactions and check for the fields on observer and proxy

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Patch coverage: 53.84% and project coverage change: -0.01 ⚠️

Comparison is base (819d47d) 77.59% compared to head (668bc81) 77.59%.

❗ Current head 668bc81 differs from pull request most recent head b1d3b3a. Consider uploading reports for the commit b1d3b3a to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##           rc/v1.5.0    #5162      +/-   ##
=============================================
- Coverage      77.59%   77.59%   -0.01%     
=============================================
  Files            654      654              
  Lines          85943    85952       +9     
=============================================
+ Hits           66685    66691       +6     
- Misses         14059    14060       +1     
- Partials        5199     5201       +2     
Impacted Files Coverage Δ
node/external/transactionAPI/unmarshaller.go 88.40% <53.84%> (-3.85%) ⬇️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed .
@@ Log scanner @@

missing-api-transaction-fields

================================================================================

  • Known Warnings 6
  • New Warnings 2
  • Known Errors 0
  • New Errors 0
  • Panics 0
    ================================================================================
  • block hash does not match 1558
  • wrong nonce in block 469
  • miniblocks does not match 0
  • num miniblocks does not match 0
  • miniblock hash does not match 0
  • block bodies does not match 0
  • receipts hash missmatch 0
    ================================================================================
  • No jailed nodes on the thestnet
    ================================================================================

@AdoAdoAdo AdoAdoAdo merged commit 361abc1 into rc/v1.5.0 Apr 7, 2023
@AdoAdoAdo AdoAdoAdo deleted the missing-api-transaction-fields branch April 7, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants