Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge branch 'rc/v1.6.0' into pubkey_15Mar #5100

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Merge branch 'rc/v1.6.0' into pubkey_15Mar #5100

merged 1 commit into from
Mar 15, 2023

Conversation

schimih
Copy link
Contributor

@schimih schimih commented Mar 15, 2023

Reasoning behind the pull request

merge

Proposed changes

merge

Testing procedure

merge

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@schimih schimih self-assigned this Mar 15, 2023
@schimih schimih merged commit efb5334 into feat/pubkeyconverter-refactor Mar 15, 2023
@schimih schimih deleted the merge_rc/v1.6.0_in_pubkey_15Mar branch March 15, 2023 09:21
@iulianpascalau iulianpascalau added the ignore-for-release-notes Do not include item in release notes label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreibancioiu andreibancioiu andreibancioiu approved these changes

@sstanculeanu sstanculeanu sstanculeanu approved these changes

Assignees

@schimih schimih

Labels
ignore-for-release-notes Do not include item in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@schimih @andreibancioiu @sstanculeanu @iulianpascalau