Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a new errChan struct that wraps an err chan #5068

Merged
merged 10 commits into from
Apr 3, 2023

Conversation

BeniaminDrasovean
Copy link
Contributor

Reasoning behind the pull request

  • The err chan that was used during the snapshotting process was prone to incorrect usage.

Proposed changes

  • Create a new struct that wraps the err chan. This new struct will prevent the wrongful usage of the err chan.

Testing procedure

  • Normal testing procedure.

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2023

Codecov Report

Patch coverage: 89.41% and no project coverage change.

Comparison is base (48b11b6) 75.73% compared to head (6a1b1c8) 75.74%.

❗ Current head 6a1b1c8 differs from pull request most recent head 3c0f4df. Consider uploading reports for the commit 3c0f4df to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           rc/v1.5.0    #5068   +/-   ##
==========================================
  Coverage      75.73%   75.74%           
==========================================
  Files            649      650    +1     
  Lines          85443    85464   +21     
==========================================
+ Hits           64712    64735   +23     
+ Misses         15640    15639    -1     
+ Partials        5091     5090    -1     
Impacted Files Coverage Δ
common/channels.go 100.00% <ø> (ø)
factory/processing/processComponents.go 66.02% <0.00%> (ø)
trie/trieStorageManager.go 63.03% <20.00%> (-0.39%) ⬇️
update/genesis/export.go 62.54% <33.33%> (ø)
trie/patriciaMerkleTrie.go 73.90% <75.00%> (ø)
common/errChan/errChan.go 100.00% <100.00%> (ø)
debug/process/stateExport.go 63.33% <100.00%> (ø)
epochStart/metachain/systemSCs.go 70.42% <100.00%> (ø)
node/node.go 68.50% <100.00%> (ø)
node/trieIterators/delegatedListProcessor.go 84.07% <100.00%> (ø)
... and 7 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@iulianpascalau iulianpascalau self-requested a review March 14, 2023 10:41
@ssd04 ssd04 self-requested a review March 15, 2023 12:43
iulianpascalau
iulianpascalau previously approved these changes Mar 15, 2023
ssd04
ssd04 previously approved these changes Mar 15, 2023
@BeniaminDrasovean BeniaminDrasovean dismissed stale reviews from ssd04 and iulianpascalau via 35fa280 March 16, 2023 11:12
ssd04
ssd04 previously approved these changes Mar 16, 2023
gabi-vuls
gabi-vuls previously approved these changes Mar 21, 2023
Copy link
Contributor

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed .

@@ Log scanner @@

refactor-err-chan

================================================================================

  • Known Warnings 12
  • New Warnings 3
  • Known Errors 0
  • New Errors 0
  • Panics 0
    ================================================================================
  • block hash does not match 15789
  • wrong nonce in block 4257
  • miniblocks does not match 0
  • num miniblocks does not match 0
  • miniblock hash does not match 0
  • block bodies does not match 0
  • receipts hash missmatch 1
    ================================================================================
  • No jailed nodes on the thestnet
    ================================================================================

iulianpascalau
iulianpascalau previously approved these changes Mar 29, 2023
@iulianpascalau iulianpascalau merged commit f29f696 into rc/v1.5.0 Apr 3, 2023
@iulianpascalau iulianpascalau deleted the refactor-err-chan branch April 3, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants