-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create a new errChan struct that wraps an err chan #5068
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## rc/v1.5.0 #5068 +/- ##
==========================================
Coverage 75.73% 75.74%
==========================================
Files 649 650 +1
Lines 85443 85464 +21
==========================================
+ Hits 64712 64735 +23
+ Misses 15640 15639 -1
+ Partials 5091 5090 -1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
35fa280
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
System test passed .
@@ Log scanner @@
refactor-err-chan
================================================================================
- Known Warnings 12
- New Warnings 3
- Known Errors 0
- New Errors 0
- Panics 0
================================================================================ - block hash does not match 15789
- wrong nonce in block 4257
- miniblocks does not match 0
- num miniblocks does not match 0
- miniblock hash does not match 0
- block bodies does not match 0
- receipts hash missmatch 1
================================================================================ - No jailed nodes on the thestnet
================================================================================
5acd29c
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
feat
branch created?feat
branch merging, do all satellite projects have a proper tag insidego.mod
?