Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge branch 'rc/v1.6.0' into feat/pubkey_conv #5066

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

schimih
Copy link
Contributor

@schimih schimih commented Mar 8, 2023

Reasoning behind the pull request

merge

Proposed changes

merge

Testing procedure

merge

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@schimih schimih self-assigned this Mar 8, 2023
sstanculeanu
sstanculeanu previously approved these changes Mar 8, 2023
bogdan-rosianu
bogdan-rosianu previously approved these changes Mar 8, 2023
@schimih schimih dismissed stale reviews from bogdan-rosianu and sstanculeanu via 61ad141 March 8, 2023 14:44
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (feat/pubkeyconverter-refactor@543dc13). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head ec5b2f3 differs from pull request most recent head 61ad141. Consider uploading reports for the commit 61ad141 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@                       Coverage Diff                        @@
##             feat/pubkeyconverter-refactor    #5066   +/-   ##
================================================================
  Coverage                                 ?   70.88%           
================================================================
  Files                                    ?      675           
  Lines                                    ?    87605           
  Branches                                 ?        0           
================================================================
  Hits                                     ?    62099           
  Misses                                   ?    20830           
  Partials                                 ?     4676           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@schimih schimih merged commit ce1aa36 into feat/pubkeyconverter-refactor Mar 8, 2023
@schimih schimih deleted the merge_rc1.6.0_in_pubkey branch March 8, 2023 15:00
@andreibancioiu andreibancioiu restored the merge_rc1.6.0_in_pubkey branch March 9, 2023 13:22
@schimih schimih deleted the merge_rc1.6.0_in_pubkey branch March 15, 2023 11:49
@schimih schimih added the ignore-for-release-notes Do not include item in release notes label May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes Do not include item in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants