Bug-fix outport data provider #5043
Conversation
| @@ -160,7 +164,8 @@ func (tep *transactionsFeeProcessor) prepareScrsNoTx(transactionsAndScrs *transa | |||
|
|
|||
| txFromStorage, err := tep.txGetter.GetTxByHash(scr.OriginalTxHash) | |||
| if err != nil { | |||
| return err | |||
| tep.log.Trace("transactionsFeeProcessor.prepareScrsNoTx: cannot find transaction in storage", "hash", scr.OriginalTxHash, "error", err.Error()) | |||
There was a problem hiding this comment.
the only clean way to test that the log.Trace function was called 👍
| @@ -37,6 +40,7 @@ func NewTransactionsFeeProcessor(arg ArgTransactionsFeeProcessor) (*transactions | |||
| txFeeCalculator: arg.TxFeeCalculator, | |||
| shardCoordinator: arg.ShardCoordinator, | |||
| txGetter: newTxGetter(arg.TransactionsStorer, arg.Marshaller), | |||
| log: logger.GetOrCreate("outport/process/transactionsfee"), | |||
There was a problem hiding this comment.
we can either have the constant string defined as a constant or the log instance declared as a var to comply with the rest of the project.
There was a problem hiding this comment.
added a const for the logger name
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## feat/polaris-fixes #5043 +/- ##
=====================================================
Coverage ? 70.79%
=====================================================
Files ? 649
Lines ? 85376
Branches ? 0
=====================================================
Hits ? 60442
Misses ? 20395
Partials ? 4539 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
The base branch was changed.
# Conflicts: # outport/process/transactionsfee/transactionsFeeProcessor.go # outport/process/transactionsfee/transactionsFeeProcessor_test.go
Reasoning behind the pull request
transactionsFeeProcessorcomponent found a smart contract result with a refund but the original transaction is not found in storage/Proposed changes
Testing procedure
shardProcessor.indexBlockIfNeeded cannot prepare argSaveBlockwill no appears in the log files.Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?