Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relayed guard accounts semi integration tests #5038

Conversation

iulianpascalau
Copy link
Contributor

Reasoning behind the pull request

  • added semi-integration tests for guarded accounts & relayed (v1 + v2) transactions
  • cleaned up redundant gasPrice definitions in tests

Proposed changes

  • added semi-integration tests for guarded accounts & relayed (v1 + v2) transactions
  • cleaned up redundant gasPrice definitions in tests

Testing procedure

  • N/A

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2023

Codecov Report

Base: 70.80% // Head: 70.85% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (9737033) compared to base (65b0045).
Patch coverage: 87.16% of modified lines in pull request are covered.

❗ Current head 9737033 differs from pull request most recent head ee1b4aa. Consider uploading reports for the commit ee1b4aa to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@                   Coverage Diff                   @@
##           feat/freeze-account    #5038      +/-   ##
=======================================================
+ Coverage                70.80%   70.85%   +0.04%     
=======================================================
  Files                      644      650       +6     
  Lines                    85033    85790     +757     
=======================================================
+ Hits                     60211    60788     +577     
- Misses                   20304    20447     +143     
- Partials                  4518     4555      +37     
Impacted Files Coverage Δ
api/gin/common.go 30.95% <ø> (ø)
api/gin/httpServer.go 23.80% <ø> (ø)
api/gin/webServer.go 0.00% <ø> (ø)
api/gin/writers.go 0.00% <ø> (ø)
api/groups/addressGroup.go 72.64% <ø> (ø)
api/groups/addressGroupOptions.go 84.61% <ø> (ø)
api/groups/baseGroup.go 79.48% <ø> (ø)
api/groups/blockGroup.go 74.67% <ø> (ø)
api/groups/hardforkGroup.go 81.25% <ø> (ø)
api/groups/networkGroup.go 95.48% <ø> (ø)
... and 164 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@iulianpascalau iulianpascalau merged commit 9874f5e into feat/freeze-account Feb 28, 2023
@iulianpascalau iulianpascalau deleted the relayed-guard-accounts-semi-integration-tests branch February 28, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants