Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add guardian service UID #4816

Merged
merged 2 commits into from
Dec 23, 2022
Merged

Conversation

AdoAdoAdo
Copy link
Contributor

@AdoAdoAdo AdoAdoAdo commented Dec 19, 2022

Reasoning behind the pull request

Guardian Service UID needs to be linked to the guardian address

Proposed changes

Change the SetGuardian builtin function to have an additional parameter for the ServiceUID and save both the guardian and the service together

Testing procedure

Use the SetGuardian builtin function to set a guardian both with unguarded (normal) and guarded(co-signed) transactions
Check that the guardian with the aditional service ID has been set in the user account, using the guardian-data api.

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@AdoAdoAdo AdoAdoAdo marked this pull request as draft December 19, 2022 15:56
@AdoAdoAdo AdoAdoAdo marked this pull request as ready for review December 20, 2022 09:53
@AdoAdoAdo AdoAdoAdo merged commit 2330a21 into feat/freeze-account Dec 23, 2022
@AdoAdoAdo AdoAdoAdo deleted the add-serviceuid-guardian branch December 23, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants