Data trie value #4686
Merged
Data trie value #4686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssd04
reviewed
Nov 11, 2022
ssd04
previously approved these changes
Nov 11, 2022
| "github.com/ElrondNetwork/elrond-go-core/core/keyValStorage" | ||
| ) | ||
|
|
||
| type disabledTrieLeafParser struct { |
There was a problem hiding this comment.
maybe rename this to trieLeafParserV1 ?
As this will be the first version we have implemented
And the package should be parsers ?
There was a problem hiding this comment.
Refactored.
iulianpascalau
approved these changes
Nov 14, 2022
ssd04
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
GetAllLeavesOnChannel().Proposed changes
disabledTrieLeafParser()toGetAllLeavesOnChannel(). This will be changed to a new implementation oftrieLeafParserin a future PR.Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?