Removed duplicated code #4643
Merged
Removed duplicated code #4643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdan-rosianu
approved these changes
Oct 26, 2022
| metaHdrHashNonceUnit, err := storageunit.NewStorageUnitFromConf( | ||
| GetCacherFromConfig(psf.generalConfig.MetaHdrNonceHashStorage.Cache), | ||
| metaHdrHashNonceUnitConfig) | ||
| peerAccountsUnit, err := psf.createTriePruningStorer(psf.generalConfig.PeerAccountsTrieStorage, customDatabaseRemover) |
There was a problem hiding this comment.
This is not created correctly for shard. When creating the peersUnit for shard, it needs to have a normal persistersTracker, not a triePersisterTracker. That is because we do not snapshot the peer state for shards, so there is no need to manage the opening and closing of the dbs in a special manner.
BeniaminDrasovean
approved these changes
Oct 27, 2022
bogdan-rosianu
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?