Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing storage resolver for validator info #4566

Merged

Conversation

sstanculeanu
Copy link
Collaborator

@sstanculeanu sstanculeanu commented Oct 7, 2022

Description of the reasoning behind the pull request (what feature was missing / how the problem was manifesting itself / what was the motive behind the refactoring)

  • import DB fails due to missing resolver on validatorInfo topic

Proposed Changes

  • added a storage resolver for validatorInfo topic

Testing procedure

  • import db + standard system test

SebastianMarian
SebastianMarian previously approved these changes Oct 7, 2022
iulianpascalau
iulianpascalau previously approved these changes Oct 7, 2022
deleted disabled validator info resolver
update currentEpochValidatorInfoPool to return a copy of the element on getter
@sstanculeanu sstanculeanu changed the title Fix missing disabled resolver on storage resolvers Fix missing storage resolver for validator info Oct 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2022

Codecov Report

Base: 70.72% // Head: 70.72% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (5b6b60e) compared to base (c44546e).
Patch coverage: 75.75% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##           rc/v1.4.0    #4566      +/-   ##
=============================================
- Coverage      70.72%   70.72%   -0.01%     
=============================================
  Files            631      631              
  Lines          83901    83927      +26     
=============================================
+ Hits           59339    59357      +18     
- Misses         20121    20125       +4     
- Partials        4441     4445       +4     
Impacted Files Coverage Δ
...esolversContainer/metaResolversContainerFactory.go 73.19% <33.33%> (-0.63%) ⬇️
...solversContainer/shardResolversContainerFactory.go 73.33% <33.33%> (-0.82%) ⬇️
...esolversContainer/baseResolversContainerFactory.go 78.08% <77.77%> (-0.05%) ⬇️
...etriever/dataPool/currentEpochValidatorInfoPool.go 100.00% <100.00%> (ø)
dataRetriever/storageResolvers/sliceResolver.go 94.02% <100.00%> (+0.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

iulianpascalau
iulianpascalau previously approved these changes Oct 13, 2022
Copy link
Collaborator Author

@sstanculeanu sstanculeanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

green, looks good 👍

Copy link
Contributor

@iulianpascalau iulianpascalau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import-db process completed successfully on all shards:
Shard 0 validated until epoch 30
Shard 1 validated until epoch 30
Shard 2 validated until epoch 30
Shard meta validated until epoch 32

Copy link
Contributor

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

system test passed

@iulianpascalau iulianpascalau merged commit 85a3c10 into rc/v1.4.0 Nov 7, 2022
@iulianpascalau iulianpascalau deleted the fix_missing_disabled_resolver_on_storage_resolvers branch November 7, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants