-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing storage resolver for validator info #4566
Fix missing storage resolver for validator info #4566
Conversation
deleted disabled validator info resolver update currentEpochValidatorInfoPool to return a copy of the element on getter
244cd11
Codecov ReportBase: 70.72% // Head: 70.72% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## rc/v1.4.0 #4566 +/- ##
=============================================
- Coverage 70.72% 70.72% -0.01%
=============================================
Files 631 631
Lines 83901 83927 +26
=============================================
+ Hits 59339 59357 +18
- Misses 20121 20125 +4
- Partials 4441 4445 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
green, looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import-db process completed successfully on all shards:
Shard 0 validated until epoch 30
Shard 1 validated until epoch 30
Shard 2 validated until epoch 30
Shard meta validated until epoch 32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
system test passed
Description of the reasoning behind the pull request (what feature was missing / how the problem was manifesting itself / what was the motive behind the refactoring)
validatorInfo
topicProposed Changes
validatorInfo
topicTesting procedure