Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heartbeatv2 config extra check #4499

Merged
merged 2 commits into from
Sep 23, 2022
Merged

Conversation

sstanculeanu
Copy link
Collaborator

Description of the reasoning behind the pull request (what feature was missing / how the problem was manifesting itself / what was the motive behind the refactoring)

  • HeartbeatExpiryTimespanInSec must be greater than PeerAuthenticationTimeBetweenSendsInSec

Proposed Changes

  • add check into HeartbeatV2Components creation to ensure this is satisfied

Testing procedure

  • standard system test

@codecov-commenter
Copy link

Codecov Report

Base: 71.18% // Head: 71.18% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (5c653a1) compared to base (534f082).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##           rc/v1.4.0    #4499      +/-   ##
=============================================
- Coverage      71.18%   71.18%   -0.01%     
=============================================
  Files            662      662              
  Lines          85839    85840       +1     
=============================================
- Hits           61106    61103       -3     
- Misses         20242    20244       +2     
- Partials        4491     4493       +2     
Impacted Files Coverage Δ
...t/processor/peerAuthenticationRequestsProcessor.go 94.82% <ø> (-0.05%) ⬇️
factory/heartbeat/heartbeatV2Components.go 75.83% <100.00%> (+0.32%) ⬆️
common/pidQueue.go 93.33% <0.00%> (-3.34%) ⬇️
p2p/libp2p/netMessenger.go 80.02% <0.00%> (-0.27%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ssd04 ssd04 self-requested a review September 22, 2022 11:01
Copy link
Contributor

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed.

@gabi-vuls gabi-vuls merged commit 894a3d7 into rc/v1.4.0 Sep 23, 2022
@gabi-vuls gabi-vuls deleted the heartbeatv2_config_extra_check branch September 23, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants