Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move integration tests #4493

Merged
merged 3 commits into from
Sep 22, 2022
Merged

Conversation

sstanculeanu
Copy link
Collaborator

Description of the reasoning behind the pull request (what feature was missing / how the problem was manifesting itself / what was the motive behind the refactoring)

  • some tests can be safely moved to elrond-go-p2p

Proposed Changes

  • move tests

Testing procedure

  • integration tests only

@sstanculeanu sstanculeanu added ignore-for-release-notes Do not include item in release notes area:integration-tests labels Sep 21, 2022
@sstanculeanu sstanculeanu self-assigned this Sep 21, 2022
@ssd04 ssd04 self-requested a review September 21, 2022 15:25
Base automatically changed from integrate-elrond-go-p2p to feat/p2p-separate-repo September 22, 2022 06:35
@sstanculeanu sstanculeanu marked this pull request as ready for review September 22, 2022 06:35
@iulianpascalau iulianpascalau self-requested a review September 22, 2022 06:36
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (feat/p2p-separate-repo@c557cf3). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                    Coverage Diff                    @@
##             feat/p2p-separate-repo    #4493   +/-   ##
=========================================================
  Coverage                          ?   72.97%           
=========================================================
  Files                             ?      620           
  Lines                             ?    82927           
  Branches                          ?        0           
=========================================================
  Hits                              ?    60517           
  Misses                            ?    17645           
  Partials                          ?     4765           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@iulianpascalau iulianpascalau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cross checked with multiversx/mx-chain-p2p-go#3 and it appears to be ok

@sstanculeanu sstanculeanu merged commit 49c6b5f into feat/p2p-separate-repo Sep 22, 2022
@sstanculeanu sstanculeanu deleted the move_integration_tests branch September 22, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:integration-tests ignore-for-release-notes Do not include item in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants