Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added request timeout for notifier http client #4475

Merged
merged 5 commits into from
Sep 20, 2022

Conversation

ssd04
Copy link
Contributor

@ssd04 ssd04 commented Sep 16, 2022

Description of the reasoning behind the pull request (what feature was missing / how the problem was manifesting itself / what was the motive behind the refactoring)

  • There was no http request timeout in notifier client, so this can cause connection issues

Proposed Changes

  • added config variable for request timeout in seconds
  • refactor http client wrapper for notifier

Testing procedure

  • System test with notifier client enabled:
    • check if request gets timeout in case proxy instance is hanging

@ssd04 ssd04 self-assigned this Sep 16, 2022
@ssd04 ssd04 changed the title added request timeout seconds for notifier http client + refactorings Added request timeout for notifier http client Sep 16, 2022
@bogdan-rosianu bogdan-rosianu self-requested a review September 16, 2022 11:32
@iulianpascalau iulianpascalau self-requested a review September 16, 2022 11:36
bogdan-rosianu
bogdan-rosianu previously approved these changes Sep 16, 2022
iulianpascalau
iulianpascalau previously approved these changes Sep 16, 2022
@ssd04 ssd04 dismissed stale reviews from iulianpascalau and bogdan-rosianu via 93e9ba2 September 16, 2022 12:48
@codecov-commenter
Copy link

Codecov Report

Base: 73.87% // Head: 73.87% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (93e9ba2) compared to base (05f6f1d).
Patch coverage: 96.22% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           rc/v1.4.0    #4475   +/-   ##
==========================================
  Coverage      73.87%   73.87%           
==========================================
  Files            692      692           
  Lines          88308    88337   +29     
==========================================
+ Hits           65234    65261   +27     
- Misses         18160    18161    +1     
- Partials        4914     4915    +1     
Impacted Files Coverage Δ
outport/factory/notifierFactory.go 92.30% <80.00%> (-7.70%) ⬇️
factory/statusComponents.go 58.50% <100.00%> (+0.28%) ⬆️
outport/notifier/eventNotifier.go 84.15% <100.00%> (+2.34%) ⬆️
outport/notifier/httpClientWrapper.go 73.33% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed.

@ssd04 ssd04 merged commit ceabff3 into rc/v1.4.0 Sep 20, 2022
@ssd04 ssd04 deleted the fix-notifier-client-timeout-issue branch September 20, 2022 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants