State snapshot improvement #4459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## rc/v1.4.0 #4459 +/- ##
==========================================
Coverage 73.84% 73.84%
==========================================
Files 689 689
Lines 88127 88146 +19
==========================================
+ Hits 65075 65092 +17
- Misses 18140 18141 +1
- Partials 4912 4913 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| if errors.IsClosingError(err) { | ||
| return nil, err | ||
| } | ||
| if len(val) != 0 { | ||
| stsm.putInPreviousStorerIfAbsent(key, val, epoch) |
There was a problem hiding this comment.
putIfAbsent :D
brings back so many memories
| return | ||
| } | ||
|
|
||
| if epoch.Value >= stsm.epoch-1 { |
There was a problem hiding this comment.
so basically, if we are in current epoch 500, epoch will be 499 and we test for epoch 498?
Is this >= correct?
There was a problem hiding this comment.
The idea is that if the value was not retrieved from the current storer or previous storer, it needs to be saved to the previous storer.
iulianpascalau
previously approved these changes
Sep 13, 2022
sstanculeanu
previously approved these changes
Sep 13, 2022
0e4f225
sstanculeanu
approved these changes
Sep 13, 2022
iulianpascalau
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the reasoning behind the pull request (what feature was missing / how the problem was manifesting itself / what was the motive behind the refactoring)
Proposed Changes
Testing procedure