Heartbeat sender factory #4455
Merged
Heartbeat sender factory #4455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
integrate_heartbeat_sender
to
feat/multisigner
September 12, 2022 10:51
…_sender_factory # Conflicts: # heartbeat/sender/sender.go
Codecov Report
@@ Coverage Diff @@
## feat/multisigner #4455 +/- ##
====================================================
+ Coverage 73.92% 73.95% +0.02%
====================================================
Files 697 698 +1
Lines 88727 88808 +81
====================================================
+ Hits 65589 65675 +86
+ Misses 18204 18200 -4
+ Partials 4934 4933 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| @@ -59,3 +66,26 @@ func (chs *commonHeartbeatSender) generateMessageBytes( | |||
|
|
|||
| return chs.marshaller.Marshal(msg) | |||
| } | |||
|
|
|||
| // GetCurrentNodeType will return the current sender type and subtype | |||
| func (chs *commonHeartbeatSender) GetCurrentNodeType() (string, core.P2PPeerSubType, error) { | |||
There was a problem hiding this comment.
👍 less duplicated code
|
|
||
| _, _, err = nodesCoordinator.GetValidatorWithPublicKey(pkBytes) | ||
| if err == nil && isMultikey { | ||
| return false, heartbeat.ErrInvalidConfiguration |
There was a problem hiding this comment.
we might return more info here, for easier debugging.
Something like:
return false, fmt.Errorf("%w, len(keysMap) = %d, isValidator = %v", heartbeat.ErrInvalidConfiguration, len(keysMap) > 0, err == nil)| hbSender, err := createHeartbeatSender(args) | ||
| assert.Nil(t, err) | ||
| assert.False(t, check.IfNil(hbSender)) | ||
| assert.Equal(t, "*sender.heartbeatSender", fmt.Sprintf("%T", hbSender)) |
| @@ -41,7 +42,7 @@ type ArgSender struct { | |||
|
|
|||
| // sender defines the component which sends authentication and heartbeat messages | |||
| type sender struct { | |||
| heartbeatSender *heartbeatSender | |||
| heartbeatSender heartbeatSenderHandler | |||
There was a problem hiding this comment.
👍 for cleaning up
no way around this, thus.
| Version: Version, | ||
| WorkingDir: "workingDir", | ||
| UseLogView: true, | ||
| BaseVersion: fmt.Sprintf("%s-base", Version), |
There was a problem hiding this comment.
clear now, pushed
iulianpascalau
approved these changes
Sep 13, 2022
ssd04
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the reasoning behind the pull request (what feature was missing / how the problem was manifesting itself / what was the motive behind the refactoring)
Proposed Changes
Testing procedure