-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Outport driver stuck prints #4452
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## rc/v1.4.0 #4452 +/- ##
=============================================
+ Coverage 73.84% 73.85% +0.01%
=============================================
Files 689 689
Lines 88122 88153 +31
=============================================
+ Hits 65070 65103 +33
+ Misses 18140 18139 -1
+ Partials 4912 4911 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
bogdan-rosianu
previously approved these changes
Sep 12, 2022
raduchis
previously approved these changes
Sep 12, 2022
mihaieremia
previously approved these changes
Sep 12, 2022
- increased the timeout to 5 minutes
9f0c489
- reverted the timeout to 30 seconds
gabi-vuls
approved these changes
Sep 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
System test passed.
bogdan-rosianu
approved these changes
Sep 14, 2022
raduchis
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the reasoning behind the pull request
Proposed Changes
Testing procedure
outport.monitorCompletionOnDriver took too long