Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outport driver stuck prints #4452

Merged
merged 8 commits into from
Sep 14, 2022
Merged

Conversation

iulianpascalau
Copy link
Contributor

@iulianpascalau iulianpascalau commented Sep 12, 2022

Description of the reasoning behind the pull request

  • Whenever an outport driver gets stuck the node will stop processing new blocks as to disallow dropping information from the chain for each driver. The stop is done without much information in the node's log so any integrator hitting in to this issue will have no clue what it's happening.

Proposed Changes

  • added timeout log prints whenever a driver gets stuck

Testing procedure

  • standard testing procedure
  • start a system testnet, stop an observer, edit the external.toml file enabling the EventNotifierConnector driver without attaching a go notifier and restart the node. The node should stop adding new blocks, after ~30seconds we should have a warning log print stating outport.monitorCompletionOnDriver took too long

@iulianpascalau iulianpascalau changed the base branch from master to rc/v1.4.0 September 12, 2022 08:15
@raduchis raduchis self-requested a review September 12, 2022 08:37
@codecov-commenter
Copy link

Codecov Report

Merging #4452 (846ff81) into rc/v1.4.0 (b68f53d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##           rc/v1.4.0    #4452      +/-   ##
=============================================
+ Coverage      73.84%   73.85%   +0.01%     
=============================================
  Files            689      689              
  Lines          88122    88153      +31     
=============================================
+ Hits           65070    65103      +33     
+ Misses         18140    18139       -1     
+ Partials        4912     4911       -1     
Impacted Files Coverage Δ
outport/outport.go 100.00% <100.00%> (ø)
storage/txcache/txListBySenderMap.go 100.00% <0.00%> (+2.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

bogdan-rosianu
bogdan-rosianu previously approved these changes Sep 12, 2022
raduchis
raduchis previously approved these changes Sep 12, 2022
mihaieremia
mihaieremia previously approved these changes Sep 12, 2022
- increased the timeout to 5 minutes
Copy link
Contributor

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed.

@iulianpascalau iulianpascalau merged commit 27567a0 into rc/v1.4.0 Sep 14, 2022
@iulianpascalau iulianpascalau deleted the outport-driver-stuck-prints branch September 14, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants