Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix heartbeat monitor to properly set peer type #4410

Merged
merged 3 commits into from
Aug 31, 2022

Conversation

sstanculeanu
Copy link
Collaborator

@sstanculeanu sstanculeanu commented Aug 30, 2022

Description of the reasoning behind the pull request (what feature was missing / how the problem was manifesting itself / what was the motive behind the refactoring)

  • heartbeat v2 only responds with validator/observer as peer type on /node/heartbeatstatus

Proposed Changes

  • integrate peerTypeProvider into heartbeat v2 monitor in order to properly compute the peer type

Testing procedure

  • system test + proxy call to /node/heartbeatstatus after epoch 3(when heartbeat v1 is disabled) in order to check if eligible/waiting is displayed for validators

@codecov-commenter
Copy link

Codecov Report

Merging #4410 (6c99e25) into rc/2022-july (7d3761c) will increase coverage by 0.04%.
The diff coverage is 88.88%.

@@               Coverage Diff                @@
##           rc/2022-july    #4410      +/-   ##
================================================
+ Coverage         73.87%   73.92%   +0.04%     
================================================
  Files               677      677              
  Lines             86864    86881      +17     
================================================
+ Hits              64173    64226      +53     
+ Misses            17895    17856      -39     
- Partials           4796     4799       +3     
Impacted Files Coverage Δ
factory/heartbeatV2Components.go 74.62% <75.00%> (+0.02%) ⬆️
heartbeat/monitor/monitor.go 96.46% <100.00%> (+0.30%) ⬆️
factory/processComponentsHandler.go 13.44% <0.00%> (+2.62%) ⬆️
p2p/libp2p/netMessenger.go 80.02% <0.00%> (+3.91%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed.

@sstanculeanu sstanculeanu merged commit 2bd74ce into rc/2022-july Aug 31, 2022
@sstanculeanu sstanculeanu deleted the fix_heartbeats_api_peer_type branch August 31, 2022 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants