reference elrond-go-storage #4349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #4349 +/- ##
===============================================
- Coverage 75.25% 73.07% -2.19%
===============================================
Files 614 634 +20
Lines 82115 83442 +1327
===============================================
- Hits 61794 60973 -821
- Misses 15643 17727 +2084
- Partials 4678 4742 +64
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
# Conflicts: # update/factory/dataTrieFactory.go
# Conflicts: # .github/workflows/build_and_test.yml # .github/workflows/code-coverage.yml # .github/workflows/create_release.yml # .github/workflows/golangci-lint.yml
# Conflicts: # epochStart/bootstrap/syncValidatorStatus.go # errors/errors.go # factory/mock/coreComponentsMock.go # genesis/process/genesisBlockCreator.go # go.mod # heartbeat/process/monitor.go # integrationTests/testP2PNode.go # integrationTests/testProcessorNodeWithCoordinator.go # integrationTests/testProcessorNodeWithMultisigner.go # node/mock/factory/coreComponentsStub.go # process/block/preprocess/transactions.go # process/smartContract/hooks/blockChainHook.go
factory/processComponents.go
Outdated
| @@ -15,6 +15,9 @@ import ( | |||
| dataBlock "github.com/ElrondNetwork/elrond-go-core/data/block" | |||
| "github.com/ElrondNetwork/elrond-go-core/data/indexer" | |||
| logger "github.com/ElrondNetwork/elrond-go-logger" | |||
| storageErrorsFactory "github.com/ElrondNetwork/elrond-go-storage/factory" | |||
There was a problem hiding this comment.
Suggested change
| storageErrorsFactory "github.com/ElrondNetwork/elrond-go-storage/factory" | |
| storageFactory "github.com/ElrondNetwork/elrond-go-storage/factory" |
There was a problem hiding this comment.
storageFactory is already used. renamed to storageRepoFactory
| "github.com/ElrondNetwork/elrond-go/storage" | ||
| "github.com/ElrondNetwork/elrond-go/storage/timecache" | ||
| "github.com/ElrondNetwork/elrond-go-storage/timecache" | ||
| storage "github.com/ElrondNetwork/elrond-go-storage/types" |
There was a problem hiding this comment.
maybe
Suggested change
| storage "github.com/ElrondNetwork/elrond-go-storage/types" | |
| storageTypes "github.com/ElrondNetwork/elrond-go-storage/types" |
sstanculeanu
previously approved these changes
Aug 11, 2022
AdoAdoAdo
reviewed
Aug 11, 2022
go.mod
Outdated
| github.com/ElrondNetwork/covalent-indexer-go v1.0.6 | ||
| github.com/ElrondNetwork/elastic-indexer-go v1.2.38 | ||
| github.com/ElrondNetwork/elrond-go-core v1.1.18 | ||
| github.com/ElrondNetwork/elrond-go-crypto v1.0.1 | ||
| github.com/ElrondNetwork/elrond-go-logger v1.0.7 | ||
| github.com/ElrondNetwork/elrond-go-storage v0.0.0-20220811102708-2dc21ec20863 |
There was a problem hiding this comment.
don't forget to replace with a tag before merge
maybe add as well arwen tags
There was a problem hiding this comment.
I have added a tag for elrond-go-storage. For arwen, I think they should come in a new PR
AdoAdoAdo
previously approved these changes
Aug 11, 2022
018294d
sstanculeanu
previously approved these changes
Aug 12, 2022
The base branch was changed.
AdoAdoAdo
approved these changes
Aug 23, 2022
sstanculeanu
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the reasoning behind the pull request (what feature was missing / how the problem was manifesting itself / what was the motive behind the refactoring)
elrond-go-storageProposed Changes
Testing procedure