Fix isRelayedTransactionV2 causing ComputeTransactionType to return improper type #4138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if the transaction is of type RelayedTxV2 and the flag check is done on processRelayedTxV2
ccorcoveanu
approved these changes
May 31, 2022
dragos-rebegea
approved these changes
May 31, 2022
| @@ -183,9 +171,6 @@ func (tth *txTypeHandler) isRelayedTransactionV1(functionName string) bool { | |||
| } | |||
|
|
|||
| func (tth *txTypeHandler) isRelayedTransactionV2(functionName string) bool { | |||
| if !tth.flagRelayedTxV2.IsSet() { | |||
There was a problem hiding this comment.
we need an import-db operation to consider this change backwards compatible
iulianpascalau
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isRelayedTransactionV2does not check the flag anymore, only returns if the transaction is of typeRelayedTxV2and the flag check is done onprocessRelayedTxV2. With this check on,ComputeTransactionTypereturns typeMoveBalancefor aRelayedTxV2with the flag disabled.