Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/HeartbeatV2 #3736

Merged
merged 273 commits into from
May 20, 2022
Merged

Feat/HeartbeatV2 #3736

merged 273 commits into from
May 20, 2022

Conversation

sstanculeanu
Copy link
Collaborator

@sstanculeanu sstanculeanu commented Feb 1, 2022 •
edited by iulianpascalau
Loading

  • heartbeat sub-system complete refactor in order to reduce consumed network bandwidth

@codecov
Copy link

codecov bot commented Feb 1, 2022 •
edited
Loading

Codecov Report

Merging #3736 (9a11ba6) into development (bee78b5) will increase coverage by 0.51%.
The diff coverage is 88.08%.

❗ Current head 9a11ba6 differs from pull request most recent head 2b5d7bb. Consider uploading reports for the commit 2b5d7bb to get more accurate results

@@               Coverage Diff               @@
##           development    #3736      +/-   ##
===============================================
+ Coverage        75.24%   75.76%   +0.51%     
===============================================
  Files              614      640      +26     
  Lines            82088    84208    +2120     
===============================================
+ Hits             61769    63798    +2029     
- Misses           15641    15654      +13     
- Partials          4678     4756      +78
Impacted Files Coverage Δ
dataRetriever/interface.go 12.12% <ø> (ø)
factory/bootstrapComponentsHandler.go 61.40% <0.00%> (ø)
factory/consensusComponentsHandler.go 60.56% <0.00%> (+4.71%) ⬆️
factory/cryptoComponentsHandler.go 66.21% <0.00%> (ø)
factory/dataComponentsHandler.go 71.08% <0.00%> (ø)
factory/heartbeatComponentsHandler.go 64.17% <0.00%> (ø)
factory/networkComponentsHandler.go 78.49% <0.00%> (ø)
factory/stateComponentsHandler.go 72.04% <0.00%> (ø)
factory/statusComponentsHandler.go 16.45% <0.00%> (ø)
genesis/process/shardGenesisBlockCreator.go 40.07% <0.00%> (-0.08%) ⬇️
... and 80 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8e2413...2b5d7bb. Read the comment docs.

sstanculeanu and others added 29 commits February 7, 2022 14:56
@sstanculeanu
added heartbeatInterceptorProcessor
a8df99f
@sstanculeanu
removed test method
0945fde
@sstanculeanu
Merge pull request #3745 from ElrondNetwork/interceptors-factories
8131c1e 
Factories for interceptors
@sstanculeanu
Merge branch 'feat/heartbeat-v2' into resolvers
8e75c02
@sstanculeanu
Merge branch 'resolvers' of https://github.com/ElrondNetwork/elrond-go …
4f600d7 
…into processor
@sstanculeanu
fixes after review
6a36170
@sstanculeanu
fixes after review
d6fb1a2
@sstanculeanu
Merge branch 'resolvers' of https://github.com/ElrondNetwork/elrond-go …
19833ce 
…into processor
@sstanculeanu
small tests fixes
ac2b174
@iulianpascalau
Merge pull request #3749 from ElrondNetwork/resolvers
caaf55d 
PeerAuthenticationResolver
@sstanculeanu
fixed race condition
0088926
@sstanculeanu
Merge branch 'feat/heartbeat-v2' into processor
67ea969
@sstanculeanu
fixed multiple data races and tests fixes
eacc631
@sstanculeanu
Merge remote-tracking branch 'origin/processor' into processor
9938e67
@sstanculeanu
added generate methods to create multi data interceptors
997856e
@sstanculeanu
fixes after review: unexported structs + fixed casts
a6d6b7d
@sstanculeanu
Merge branch 'processor' of https://github.com/ElrondNetwork/elrond-go …
d2154f5 
…into processors-integration
@sstanculeanu
removed calls which were moved to other tests
d0557bb
@sstanculeanu
removed calls which were moved to other tests
c041125
@sstanculeanu
fixed typos
0964d56
@sstanculeanu
Merge branch 'processor' of https://github.com/ElrondNetwork/elrond-go …
04cc1e1 
…into processors-integration
@iulianpascalau
Merge branch 'development' into update-dev-2022.02.08
428b592 
# Conflicts:
#	p2p/libp2p/netMessenger.go
#	p2p/libp2p/netMessenger_test.go
@iulianpascalau
Merge pull request #3769 from ElrondNetwork/update-dev-2022.02.08
9d0a8f9 
Update dev 2022.02.08
@sstanculeanu
Merge branch 'feat/heartbeat-v2' into processor
84709d8
@sstanculeanu
Merge pull request #3759 from ElrondNetwork/processor
a1d2250 
Messages processors
@sstanculeanu
Merge branch 'feat/heartbeat-v2' into processors-integration
b64c25f
@iulianpascalau
- added peer authentication sender
43e687b 
- added routineHandler & timerWrapper sub-components
- renamed some interfaces, stub implementations and errors
@iulianpascalau
- fixes
ff554a6
@iulianpascalau
Merge branch 'feat/heartbeat-v2' into peer-authentication-sender
d65f11f
sstanculeanu and others added 13 commits May 13, 2022 14:13
@sstanculeanu
Merge remote-tracking branch 'origin/improvements' into improvements
29d1ea8
@sstanculeanu
fix parse int issue on meta shard
dcc9938
@sstanculeanu
no need to use ParseInt for shard
67c68d6
@sstanculeanu
fixed monitor tests
72794ec
@sstanculeanu
fixes after review
84ed722
@sstanculeanu
Merge pull request #4064 from ElrondNetwork/improvements
1e6dc85 
HeartbeatV2 improvements and fixes
@sstanculeanu
Merge remote-tracking branch 'origin/development' into merge-dev-into…
5647c83 
…-feat-heartbeat-v2-2022.05.17

# Conflicts:
#	go.mod
#	process/errors.go
@sstanculeanu
Merge pull request #4084 from ElrondNetwork/merge-dev-into-feat-heart…
bd18484 
…beat-v2-2022.05.17

Merge dev into feat heartbeat v2 2022.05.17
@sstanculeanu
fixed long tests
d26088a
@sstanculeanu
Merge branch 'feat/heartbeat-v2' into fix-heartbeat-long-tests
d7d0a63
@sstanculeanu
Merge pull request #4085 from ElrondNetwork/fix-heartbeat-long-tests
5390f5e 
Fix long tests
@sstanculeanu
Merge remote-tracking branch 'origin/development' into merge-dev-into…
feb3a93 
…-heartbeat-v2-2022.05.20
@sstanculeanu
Merge pull request #4092 from ElrondNetwork/merge-dev-into-heartbeat-…
4ae38dd 
…v2-2022.05.20

Merge dev into heartbeat v2 2022.05.20
@sstanculeanu sstanculeanu marked this pull request as ready for review May 20, 2022 08:05
iulianpascalau
iulianpascalau approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@iulianpascalau iulianpascalau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ! 👍

gabi-vuls
gabi-vuls approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed.

@sstanculeanu sstanculeanu merged commit 3bae78e into development May 20, 2022
@sstanculeanu sstanculeanu deleted the feat/heartbeat-v2 branch May 20, 2022 10:43
@sstanculeanu sstanculeanu changed the title Feat/heartbeat-v2 Feat/HeartbeatV2 Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabi-vuls gabi-vuls gabi-vuls approved these changes

@iulianpascalau iulianpascalau iulianpascalau approved these changes

@ssd04 ssd04 ssd04 approved these changes

Assignees

@sstanculeanu sstanculeanu

Labels
area:heartbeat area:libp2p area:processing complexity:high impact:medium interested:protocol size:large type:feature New feature or request type:improvement type:refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sstanculeanu @codecov-commenter @ssd04 @iulianpascalau @gabi-vuls