En 3563 update term ui #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t implementing on this feature
…rn error if termui console is nil, rename some methods
…3395-termui-console
# Conflicts: # core/constants.go
…3395-termui-console
added local machine metrics
…work/elrond-go into EN-3395-termui-console # Conflicts: # cmd/node/main.go # core/constants.go # statusHandler/termuiStatusHandler.go # statusHandler/termuic/termuiRenders/widgetsRender.go
…3395-termui-console
updated some texts in widgets modified config.toml to poll each 2 seconds added parameter name in interface definition
…3395-termui-console
…work/elrond-go into EN-3395-termui-console
…work/elrond-go into EN-3395-termui-console
code refactoring in termui render added version label in termui render
# Conflicts: # cmd/node/main.go # core/constants.go # statusHandler/termuiStatusHandler.go # statusHandler/termuiStatusHandler_test.go # statusHandler/termuic/termuiConsole.go # statusHandler/termuic/termuiRenders/widgetsRender.go
raduchis
previously approved these changes
Aug 14, 2019
camilbancioiu
previously approved these changes
Aug 14, 2019
api/api.go
Outdated
| @@ -33,6 +33,7 @@ type prometheus struct { | |||
| // MainApiHandler interface defines methods that can be used from `elrondFacade` context variable | |||
| type MainApiHandler interface { | |||
| RestApiPort() string | |||
| GinDebugMode() bool | |||
There was a problem hiding this comment.
Could rename Gin to RestAPIServer.
cmd/node/main.go
Outdated
| @@ -642,7 +643,7 @@ func startNode(ctx *cli.Context, log *logger.Logger, version string) error { | |||
| return err | |||
| } | |||
|
|
|||
| ef := facade.NewElrondNodeFacade(currentNode, apiResolver) | |||
| ef := facade.NewElrondNodeFacade(currentNode, apiResolver, !useTermui) | |||
There was a problem hiding this comment.
For readability, you could write above: ginDebugMode := !useTermui then pass it as the argument to NewElrondNodeFacade.
| func TestTermuiStatusHandler_TestIncrement(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| var metricKey = core.MetricNonce | ||
|
|
||
| termuiStatusHandler := statusHandler.NewTermuiStatusHandler() | ||
|
|
||
| termuiStatusHandler.SetUInt64Value(metricKey, 0) |
There was a problem hiding this comment.
For readability, delete var metricKey and use core.MetricNonce directly as the arguments to SetUInt64Value here.
0295f50
raduchis
approved these changes
Aug 14, 2019
camilbancioiu
approved these changes
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated gin to start in debug mode only if termui is not enabled
code refactoring in termui render
added version label in termui render