Liquid staking unit and integration tests #3385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-tests Liquid staking integration tests
| @@ -2275,7 +2343,7 @@ func (tpn *TestProcessorNode) LoadTxSignSkBytes(skBytes []byte) { | |||
| // ProposeBlock proposes a new block | |||
| func (tpn *TestProcessorNode) ProposeBlock(round uint64, nonce uint64) (data.BodyHandler, data.HeaderHandler, [][]byte) { | |||
| startTime := time.Now() | |||
| maxTime := time.Second * 2 | |||
| maxTime := time.Second * 200000 | |||
| idxProposers[numOfShards] = numOfShards * nodesPerShard | ||
|
|
||
| var tokenID []byte | ||
| for _, node := range nodes { |
There was a problem hiding this comment.
this can be extracted in a function for reusability purposes
There was a problem hiding this comment.
would leave as it is.
| output := d.Execute(vmInput) | ||
| assert.Equal(t, vmcommon.UserError, output) | ||
| assert.True(t, strings.Contains(eei.returnMessage, "error getting minimum delegation amount")) | ||
| assert.True(t, strings.Contains(eei.returnMessage, "invalid value to undelegate - need to undelegate all - do not leave dust behind")) |
There was a problem hiding this comment.
is this backwards compatible?
There was a problem hiding this comment.
yes. it is. Error getting minimum amount does not happen at all. Only if delegation management was not instantiated.
| remainedFund := big.NewInt(0).Sub(activeFund.Value, valueToUnDelegate) | ||
| if remainedFund.Cmp(zero) > 0 && remainedFund.Cmp(minDelegationAmount) < 0 { | ||
| err = d.checkRemainingFundValue(remainedFund) | ||
| if err != nil { | ||
| d.eei.AddReturnMessage("invalid value to undelegate - need to undelegate all - do not leave dust behind") |
There was a problem hiding this comment.
d.eei.AddReturnMessage(err.Error()) ?
There was a problem hiding this comment.
no, this has to be left as it is for backward compatibility purposes.
…liquid-staking-unit-tests
iulianpascalau
approved these changes
Aug 30, 2021
SebastianMarian
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Liquid staking unit tests
Liquid staking integration tests