Create ticker on metachain #3363
Conversation
| @@ -1816,12 +1824,30 @@ func (d *delegation) computeAndUpdateRewards(callerAddress []byte, delegator *De | |||
|
|
|||
| isOwner := d.isOwner(callerAddress) | |||
|
|
|||
| totalRewards, err := d.computeRewards(delegator.RewardsCheckpoint, isOwner, activeFund.Value) | |||
There was a problem hiding this comment.
The error returned here is not managed below in any way
| d.eei.AddReturnMessage("not enough arguments") | ||
| return vmcommon.UserError | ||
| } | ||
| err := d.eei.UseGas(d.gasCost.MetaChainSystemSCsCost.DelegationOps) |
There was a problem hiding this comment.
DelegationOps is ok also for liquidStaking or we should define another special cost for it ?
There was a problem hiding this comment.
we also use liquid staking ops cost as well - from liquid staking manager contract.
| err := d.eei.UseGas(d.gasCost.MetaChainSystemSCsCost.DelegationOps) | ||
| if err != nil { | ||
| d.eei.AddReturnMessage(err.Error()) | ||
| return vmcommon.UserError |
| } | ||
|
|
||
| if len(args.Arguments) != 3 { | ||
| d.eei.AddReturnMessage("not enough arguments") |
There was a problem hiding this comment.
invalid number of arguments ?
| return vmcommon.Ok | ||
| } | ||
|
|
||
| func (d *delegation) reDelegateRewardsViaLiquidStaking(args *vmcommon.ContractCallInput) vmcommon.ReturnCode { |
There was a problem hiding this comment.
These methods (reDelegateRewardsViaLiquidStaking, unDelegateViaLiquidStaking and returnViaLiquidStaking) will be implemented in this PR?
There was a problem hiding this comment.
in the next PR
| return vmcommon.UserError | ||
| } | ||
| if args.CallValue.Cmp(zero) != 0 { | ||
| l.eei.AddReturnMessage("not a payable function") |
There was a problem hiding this comment.
"function is not payable in eGLD" to keep the same message format used in all the other methods from this file
| return vmcommon.UserError | ||
| } | ||
| if len(args.Arguments) == 0 { | ||
| l.eei.AddReturnMessage("not enough arguments") |
There was a problem hiding this comment.
"invalid number of arguments" ?
There was a problem hiding this comment.
this has concrete check on next PR.
| return vmcommon.Ok | ||
| } | ||
|
|
||
| func (l *liquidStaking) claimRewardsFromDelegatedPosition(args *vmcommon.ContractCallInput) vmcommon.ReturnCode { |
There was a problem hiding this comment.
claimRewardsViaLiquidStaking is already implemented in delegation.go. This method shouldn't be also implemented?
There was a problem hiding this comment.
methods from delegation.go can be called by liquidStaking contract only
| return vmcommon.Ok | ||
| } | ||
|
|
||
| func (l *liquidStaking) reDelegateRewardsFromPosition(args *vmcommon.ContractCallInput) vmcommon.ReturnCode { |
There was a problem hiding this comment.
These next methods will be implemented in this PR ?
| message LiquidStakingAttributes { | ||
| bytes ContractAddress = 1 [(gogoproto.jsontag) = "ContractAddress"]; | ||
| uint32 RewardsCheckpoint = 2 [(gogoproto.jsontag) = "RewardsCheckpoint"]; | ||
| } |
| value := big.NewInt(0).SetBytes(args.Arguments[1]) | ||
| checkPoint := uint32(big.NewInt(0).SetBytes(args.Arguments[2]).Uint64()) | ||
|
|
||
| totalRewards, err := d.computeRewards(checkPoint, false, value) |
There was a problem hiding this comment.
so the claim operation via liquid staking will also take all unclaimed rewards (if existing) before creating the liquid position, right?
| } | ||
|
|
||
| // ArgsNewLiquidStaking defines the arguments to create the liquid staking smart contract | ||
| type ArgsNewLiquidStaking struct { |
There was a problem hiding this comment.
according to our last talk about naming convention, this should be LiquidStakingArgs
| return vmcommon.UserError | ||
| } | ||
| if !l.flagLiquidStaking.IsSet() { | ||
| l.eei.AddReturnMessage("liquid staking contract is not enabled") |
There was a problem hiding this comment.
I think this is not backwards compatible if we end up having a transaction towards the liquid staking contract before we have this code up and running.
There was a problem hiding this comment.
We do have this backward compatible - it is resolved directly in systemVM. line 108-110. It was done for delegation contract first. And contract have activation. They implement CanUseContract()
| const tokenIDKey = "tokenID" | ||
| const noncePrefix = "n" | ||
|
|
||
| type liquidStaking struct { |
There was a problem hiding this comment.
is this sc complete? What it does is that it just have some checks on some operations.
+ do not forget about tests.
There was a problem hiding this comment.
No. this is incomplete.
Add ticker on metachain
Add interface to process built in functions easily on metachain