Bugs/en 3228 sc processor refund gas #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an intra shard tx that has an output to that same sender account. added integration test
…8-sc-processor-refund-gas
sasurobert
requested changes
Jul 30, 2019
| var agarioFile = "agarioV2.hex" | ||
| var stepDelay = time.Second | ||
|
|
||
| func TestShouldProcessBlocksWithScTxsJoinAndRewardTheOwner(t *testing.T) { |
There was a problem hiding this comment.
reduced to 47 chars
There was a problem hiding this comment.
not the function name. but the number of the lines in the function
integrationTests/singleShard/block/executingMiniblocksSc_test.go
Outdated
Show resolved
Hide resolved
integrationTests/singleShard/block/executingMiniblocksSc_test.go
Outdated
Show resolved
Hide resolved
| nodes []*integrationTests.TestProcessorNode, | ||
| idxNode int, | ||
| joinGameVal *big.Int, | ||
| scAddress []byte) { |
| idxNodeOwner int, | ||
| idxNodeUser int, | ||
| prize *big.Int, | ||
| scAddress []byte) { |
sasurobert
reviewed
Jul 30, 2019
| syncBlock(t, nodes, idxProposer, round) | ||
| round = incrementAndPrintRound(round) | ||
|
|
||
| proposeBlock(nodes, idxProposer, round) |
There was a problem hiding this comment.
why do you need to propose and sync again ?
There was a problem hiding this comment.
Good catch! Removed.
There was a problem hiding this comment.
👍, I was about to ask the same thing, maybe a comment would be needed here as an explanation
sasurobert
requested changes
Jul 30, 2019
| scAddress []byte) { | ||
|
|
||
| fmt.Println("Calling SC.rewardAndSendToWallet...") | ||
| txDeploy := createTxRewardAndSendToWallet(nodes[idxNodeOwner], nodes[idxNodeUser], prize, scAddress) |
There was a problem hiding this comment.
this is not a deploy tx
There was a problem hiding this comment.
Indeed, fixed also multishard/block
| scAddress []byte) { | ||
|
|
||
| fmt.Println("Calling SC.joinGame...") | ||
| txDeploy := createTxJoinGame(nodes[idxNode], joinGameVal, scAddress) |
There was a problem hiding this comment.
this is not a deploy tx
…est initializer, small code reformatting, changed some variable names, removed one extra step (propose-sync) in singleshard/block executingMiniblocksSc
ccorcoveanu
requested changes
Jul 30, 2019
integrationTests/singleShard/block/executingMiniblocksSc_test.go
Outdated
Show resolved
Hide resolved
| syncBlock(t, nodes, idxProposer, round) | ||
| round = incrementAndPrintRound(round) | ||
|
|
||
| proposeBlock(nodes, idxProposer, round) |
There was a problem hiding this comment.
👍, I was about to ask the same thing, maybe a comment would be needed here as an explanation
…located in smartcontract/process in a function called reloadLocalSndAccount
….com/ElrondNetwork/elrond-go into bugs/EN-3228-sc-processor-refund-gas
sasurobert
approved these changes
Jul 30, 2019
ccorcoveanu
approved these changes
Jul 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug when refunding gas to the tx sender when executing an intra-shard sc call tx and VM changed the balance of the sender
Added integration test