fixes after review

dataRetriever/factory/containers/resolversContainer_test.go

@@ -251,7 +251,7 @@ func TestResolversContainer_IterateNilHandlerShouldNotPanic(t *testing.T) {
 	defer func() {
 		r := recover()
 		if r != nil {
-			assert.Fail(t, "should not have paniced")
+			assert.Fail(t, "should not have panicked")
 		}
 	}()
 
@@ -269,7 +269,7 @@ func TestResolversContainer_IterateNotAValidKeyShouldWorkAndNotPanic(t *testing.
 	defer func() {
 		r := recover()
 		if r != nil {
-			assert.Fail(t, "should not have paniced")
+			assert.Fail(t, "should not have panicked")
 		}
 	}()
 
@@ -292,7 +292,7 @@ func TestResolversContainer_IterateNotAValidValueShouldWorkAndNotPanic(t *testin
 	defer func() {
 		r := recover()
 		if r != nil {
-			assert.Fail(t, "should not have paniced")
+			assert.Fail(t, "should not have panicked")
 		}
 	}()
 

dataRetriever/factory/epochProviders/currentEpochProvidersFactory_test.go

@@ -25,7 +25,7 @@ func TestCreateCurrentEpochProvider_NilCurrentEpochProvider(t *testing.T) {
 	assert.IsType(t, disabled.NewEpochProvider(), cnep)
 }
 
-func TestCreateCurrentEpochProvider_ArithemticEpochProvider(t *testing.T) {
+func TestCreateCurrentEpochProvider_ArithmeticEpochProvider(t *testing.T) {
 	t.Parallel()
 
 	cnep, err := CreateCurrentEpochProvider(

dataRetriever/interface.go

@@ -316,7 +316,7 @@ type WhiteListHandler interface {
 	IsInterfaceNil() bool
 }
 
-// DebugHandler defines an interface for debugging the reqested-resolved data
+// DebugHandler defines an interface for debugging the requested-resolved data
 type DebugHandler interface {
 	LogRequestedData(topic string, hashes [][]byte, numReqIntra int, numReqCross int)
 	LogFailedToResolveData(topic string, hash []byte, err error)

dataRetriever/mock/marshalizerMock.go

@@ -32,7 +32,7 @@ func (mm *MarshalizerMock) Unmarshal(obj interface{}, buff []byte) error {
 	}
 
 	if obj == nil {
-		return errors.New("nil object to serilize to")
+		return errors.New("nil object to serialize to")
 	}
 
 	if buff == nil {

dataRetriever/resolvers/validatorInfoResolver_test.go

@@ -379,7 +379,7 @@ func TestValidatorInfoResolver_ProcessReceivedMessage(t *testing.T) {
 		require.NotNil(t, err)
 		assert.True(t, strings.Contains(err.Error(), dataRetriever.ErrValidatorInfoNotFound.Error()))
 	})
-	t.Run("pack data in chuncks returns error", func(t *testing.T) {
+	t.Run("pack data in chunks returns error", func(t *testing.T) {
 		t.Parallel()
 
 		args := createMockArgValidatorInfoResolver()

dataRetriever/shardedData/shardedData_test.go

@@ -78,7 +78,7 @@ func TestShardedData_StorageEvictsData(t *testing.T) {
 	}
 
 	assert.Less(t, sd.ShardDataStore("1").Len(), int(defaultTestConfig.Capacity),
-		"Transaction pool entries excedes the maximum configured number")
+		"Transaction pool entries exceeds the maximum configured number")
 }
 
 func TestShardedData_NoDuplicates(t *testing.T) {
@@ -228,7 +228,7 @@ func TestShardedData_RegisterAddedDataHandlerShouldWork(t *testing.T) {
 	}
 }
 
-func TestShardedData_RegisterAddedDataHandlerReallyAddsAhandler(t *testing.T) {
+func TestShardedData_RegisterAddedDataHandlerReallyAddsHandler(t *testing.T) {
 	t.Parallel()
 
 	f := func(key []byte, value interface{}) {

dataRetriever/storageRequesters/headerRequester_test.go

@@ -1,7 +1,6 @@
 package storagerequesters
 
 import (
-	"errors"
 	"math"
 	"testing"
 	"time"
@@ -140,7 +139,6 @@ func TestHeaderRequester_SetEpochHandlerShouldWork(t *testing.T) {
 func TestHeaderRequester_RequestDataFromHashNotFoundNotBufferedChannelShouldErr(t *testing.T) {
 	t.Parallel()
 
-	expectedErr := errors.New("expected error")
 	newEpochCalled := false
 	sendCalled := false
 	arg := createMockHeaderRequesterArg()
@@ -173,7 +171,6 @@ func TestHeaderRequester_RequestDataFromHashNotFoundNotBufferedChannelShouldErr(
 func TestHeaderRequester_RequestDataFromHashNotFoundShouldErr(t *testing.T) {
 	t.Parallel()
 
-	expectedErr := errors.New("expected error")
 	newEpochCalled := false
 	sendCalled := false
 	arg := createMockHeaderRequesterArg()
@@ -248,7 +245,6 @@ func TestHeaderRequester_RequestDataFromHashShouldWork(t *testing.T) {
 func TestHeaderRequester_RequestDataFromNonceNotFoundShouldErr(t *testing.T) {
 	t.Parallel()
 
-	expectedErr := errors.New("expected error")
 	newEpochCalled := false
 	sendCalled := false
 	arg := createMockHeaderRequesterArg()
@@ -343,10 +339,9 @@ func TestHeaderRequester_RequestDataFromEpoch(t *testing.T) {
 		err := hdReq.RequestDataFromEpoch(epochIdentifier)
 		assert.Equal(t, core.ErrInvalidIdentifierForEpochStartBlockRequest, err)
 	})
-	t.Run("identifier not found should error should error", func(t *testing.T) {
+	t.Run("identifier not found should error", func(t *testing.T) {
 		t.Parallel()
 
-		expectedErr := errors.New("expected error")
 		epochIdentifier := []byte(core.EpochStartIdentifier(100))
 		arg := createMockHeaderRequesterArg()
 		arg.HdrStorage = &storageStubs.StorerStub{

dataRetriever/topicSender/diffPeerListCreator_test.go

@@ -75,7 +75,7 @@ func TestNewDiffPeerListCreator_ShouldWork(t *testing.T) {
 	assert.Equal(t, excludedTopic, dplc.ExcludedPeersOnTopic())
 }
 
-func TestMakeDiffList_EmptyExcludedShoudRetAllPeersList(t *testing.T) {
+func TestMakeDiffList_EmptyExcludedShouldRetAllPeersList(t *testing.T) {
 	t.Parallel()
 
 	allPeers := []core.PeerID{core.PeerID("peer1"), core.PeerID("peer2")}