-
-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Msgbox #464
Improved Msgbox #464
Conversation
Good job! I would just add more spacing between the title and message, as well as the icon on the left @Nico8340 |
Should there be more space vertically or horizontally? |
On the y axis between the 2 text labels, and on the x axis between the image and the texts, imo @Nico8340 |
Does they look better now? 😄 |
I think it looks fine now |
There is no way to handle when a player clicked a specific button like Ok, Cancel? Seems like all they do is close the window |
@Fernando-A-Rocha |
By the way, I would like to use this system for the new chat implementation as well, in case of mute, notify the player to end this activity or he will face a bigger sanction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just a few minor notes. This implementation will work just fine in editor_gui
and similar resources, but the admin
and admin2
resources have their own unique implementations that make use of coroutines that can't be easily replaced by this resource.
The changes have been made, but for some reason GitHub says they haven't. (they are now, it was just github's bad ux,.) |
I'm closing this pull request because I have a much better idea for the implementation that is completely different from this one. |
This PR removes the old msgbox resource and creates a new one that provides a much simpler concept and looks better.
Available types: info, question, warning, error
Available buttons: ok, okcancel, retrycancel, yesno, yesnocancel