Add ipcidr #129
Merged
Add ipcidr #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
mxinden
reviewed
Jun 15, 2022
| @@ -5,6 +5,7 @@ code, size, name, comment | |||
| 33, 16, dccp, | |||
| 41, 128, ip6, | |||
| 42, V, ip6zone, rfc4007 IPv6 zone | |||
| 43, 8, ipcidr, CIDR mask for IP addresses | |||
There was a problem hiding this comment.
Would this be used for IPv4 only? In other words, isn't an IPv6 CIDR > 8 byte?
Never mind. Sorry. This is the CIDR suffix only.
marten-seemann
approved these changes
Jun 17, 2022
|
@marten-seemann can you merge? I don’t have write access |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ipcidr to multiaddr. See multiformats/go-multiaddr#177 for the Go implementation.
Why
We want to be able to specify a set of allowed ip addresses in the resource manager. These addresses will get some special treatment. We want to be able to specify a cidr range of ip addresses, and it's convenient to include this range directly in the multiaddr rather than a separate parameter.
Other use cases: