Jbaublitz encryption #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'ld prefer it if that part of the computation wasn't in the D-Bus layer now. The purpose of the existing code is to enable the future possibility of using a different keyfile for the cache layer than for the data layer. But when that happens the keyfile will be extracted by the D-Bus layer and passed in, and at that time we can rearrange init_cache as necessary, both to take the argument and to use it properly. Signed-off-by: mulhern <amulhern@redhat.com>
They are not used. Signed-off-by: mulhern <amulhern@redhat.com>
Let's just make it impossible to setup an encrypted pool and let the solution to discovery fill in the details here. Signed-off-by: mulhern <amulhern@redhat.com>
|
Obsolete. |
mulkieran
added a commit
that referenced
this pull request
Feb 21, 2024
mulkieran
added a commit
that referenced
this pull request
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.