This repository was archived by the owner on Oct 17, 2019. It is now read-only.
Add device ID and device fingerprint to settings page like in Riot. #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2ea1c59 to
d9c3c32
Compare
mujx
suggested changes
Aug 20, 2018
src/UserSettingsPage.cpp
Outdated
| deviceIdValue_->setText(QString::fromStdString(http::client()->device_id())); | ||
|
|
||
| // TODO: Do the HumanReadable part somewhere else | ||
| QString fingerprint = QString::fromStdString(olm::client()->identity_keys().ed25519); |
src/UserSettingsPage.cpp
Outdated
| font.setWeight(65); | ||
|
|
||
| auto encryptionLabel_ = new QLabel(tr("Encryption"), this); |
There was a problem hiding this comment.
Could you add some top padding on this section so it will appear a little more distinct, like General? Also it needs to be capitalized.
src/UserSettingsPage.cpp
Outdated
|
|
||
| auto deviceFingerprintLabel = new QLabel(tr("Device Fingerprint"), this); | ||
| deviceFingerprintLabel->setFont(font); | ||
| deviceFingerprintValue_ = new QLabel(QString("Loading...")); |
There was a problem hiding this comment.
You could remove the placeholder, since the fingerprint is loaded instantly.
src/UserSettingsPage.cpp
Outdated
|
|
||
| auto deviceIdLabel = new QLabel(tr("Device ID"), this); | ||
| deviceIdLabel->setFont(font); | ||
| deviceIdValue_ = new QLabel(QString("Loading...")); |
|
|
||
| QFont monospaceFont = QFont(font); | ||
| monospaceFont.setFamily("Courier New"); | ||
| monospaceFont.setStyleHint(QFont::Courier); |
There was a problem hiding this comment.
Maybe adjust this font to be slightly smaller than the text on the left side so it would be more easily distinguishable.
mujx
approved these changes
Aug 21, 2018
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add ID and fingerprint of the device to the settings page (Part of #369)
I am not fimilar with QT so best practices may be violated.
Showing the key in the QLabel is done in UserSettingsPage::showEvent because i got some errors loading the key during creating the SettingsWidget.
The riot sdks handle the ed25519 as the fingerprint and not part of the identityKey. Mabye that should change in the olmClient.
Furthermore i do the conversion to a human readable form in showEvent as well. If you want me to create a function to do that somewhere else please tell me.