Skip to content
This repository has been archived by the owner on Oct 17, 2019. It is now read-only.

Initial Russian translate #318

Merged
merged 5 commits into from
May 14, 2018
Merged

Initial Russian translate #318

merged 5 commits into from
May 14, 2018

Conversation

bergentroll
Copy link
Contributor

@bergentroll bergentroll commented May 5, 2018

I prepaired Russian ts file, but I have no idea how I can test it. I just make update-translations and make release on enveronment with $LANG=ru_RU.utf8, but the nheko is still in English.
¯\_(ツ)_/¯

@mujx
Copy link
Owner

mujx commented May 5, 2018

Thanks a lot for the translation!

That was pretty much the way to add a new ts file but for some reason the translations don't work in general (they used to). So we have to figure out why they are not applied.

@mujx mujx added the on hold label May 9, 2018
@mujx
Copy link
Owner

mujx commented May 9, 2018

I'm putting this on hold until the issue with the translations is resolved.

@mujx mujx removed the on hold label May 13, 2018
@mujx
Copy link
Owner

mujx commented May 13, 2018

Translations are working again. Just run make update-translations again to fill some missing strings.

@bergentroll
Copy link
Contributor Author

@mujx, great! So I'll test my lang file, fix it and write you back.

@bergentroll
Copy link
Contributor Author

@mujx, done!
There is no every strings works for some reason, such as the line 102 in nheko_ru.ts. But most of are.

@mujx
Copy link
Owner

mujx commented May 14, 2018

Thanks!

We can revisit the problematic strings. I didn't have any problem with the other languages so far, so I'm out of ideas on this one.

@mujx mujx merged commit fab4133 into mujx:master May 14, 2018
vurpo pushed a commit to vurpo/nheko that referenced this pull request Jun 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants