[fields] Reset all selected state on section edit
#16223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-16223--material-ui-x.netlify.app/ |
flaviendelangle
approved these changes
Jan 17, 2025
all selected state on section edit
|
My initial assumption was incorrect. |
|
Cherry-pick PRs will be created targeting branches: v7.x |
A-s-h-o-k
pushed a commit
to A-s-h-o-k/mui-x
that referenced
this pull request
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16201.
The change resets theselectedSectionsto theactiveSectionIndexwhen modification is done with navigation keys (Arrows, End, PageUp, etc.) just like with letters.Wrong initial assumption, the selected section was only being reset on letter/digit editing when a jump to the next section was requested.
I've updated the approach to always reset the
allselection state when doing a manual modification.