Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TablePagination] Make onChangeRowsPerPage optional #9563

Merged

Conversation

evantrimboli
Copy link
Contributor

@evantrimboli evantrimboli commented Dec 20, 2017

The select field is now hidden if configured with < 2 options, so it seems as though this should also be optional.

@oliviertassinari oliviertassinari added the component: table This is the name of the generic UI component, not the React module! label Dec 20, 2017
@oliviertassinari
Copy link
Member

Let's hold on #9561 for merging.

The select option is now hidden if configured with < 2 options, so it seems as though this should be optional.
@oliviertassinari oliviertassinari force-pushed the optional-onChangeRowsPerPage branch from 00b38ff to a4bf594 Compare December 20, 2017 19:41
@oliviertassinari oliviertassinari changed the title [TablePagination] Make onChangeRowsPerPage optional. [TablePagination] Make onChangeRowsPerPage optional Dec 20, 2017
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Dec 20, 2017
@oliviertassinari oliviertassinari merged commit e807a62 into mui:v1-beta Dec 20, 2017
@evantrimboli evantrimboli deleted the optional-onChangeRowsPerPage branch December 20, 2017 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: table This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants