-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[style] Add missing blueGrey colors #6548
Conversation
A200: '#b0bec5', | ||
A400: '#78909c', | ||
A700: '#455a64', | ||
contrastDefaultColor: 'light', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where have you found those colors? I can't find them in the spec https://material.io/guidelines/style/color.html#color-color-palette. Also, we would need to update the docs if we move forward.
Ah, good points on both counts. Brown is also missing colors A100, A200, etc. in the spec and the way we dealt with that was by just setting
I propose we do one of the following:
What do we think? I feel like (1) is probably the right thing to do though I'm using Blue Grey for a project of mine so I'm tempted to do (2). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm gonna approve that PR for consistency with the other colors.
I would rather keep those colors and make apply an interpolation function util we the specification is explicit. What do you think?
I think this is fine for now :) If we were going to go as far to make a special function for computing the A* variants of a color, I'd think it'd also be worth creating methods to generate the shades 50-700 based off a single color as that would enable users to specify a single color for which we could auto-generate a whole palette. |
the
blueGrey
color is missing the colorsA100
,A200
,A400
, andA700
as well as thecontrastDefaultColor
setting which causes Material UI to throw an error if it was chosen as the primary or accent color.This adds those in :)