Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][Snackbar] Add Slots and SlotProps #45103

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

[material-ui][Snackbar] Add Slots and SlotProps #45103

wants to merge 15 commits into from

Conversation

harry-whorlow
Copy link
Contributor

@harry-whorlow harry-whorlow commented Jan 24, 2025 •
edited
Loading

part of #41281

This PR adds slot and slotProps, whilst deprecating components.

Slot:

  • slot.TransitionComponent

SlotProps:

  • slotProps.TransitionProps
  • slotProps.ContentProps,
  • slotProps.ClickAwayListenerProps

@mui-bot
Copy link

mui-bot commented Jan 24, 2025 •
edited
Loading

Netlify deploy preview

https://deploy-preview-45103--material-ui.netlify.app/

@material-ui/core: parsed: +0.11% , gzip: +0.08%

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 8da3f04

Harry Whorlow and others added 3 commits January 24, 2025 11:11
proptypes
b2db911
docs:api
d61e1cb
@harry-whorlow
docs:typescript:formatted
a53811c 
Signed-off-by: Harry Whorlow <79278353+harry-whorlow@users.noreply.github.com>
@harry-whorlow
Copy link
Contributor Author

@DiegoAndai @siriwatknp ready for review!

harry-whorlow
harry-whorlow commented Jan 24, 2025
View reviewed changes
docs/data/material/components/snackbars/TransitionsSnackbar.tsx.preview Outdated
/>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small point

This is why the docs:typescript:formatted is failing, but I'm confused as to why... As every other example of ---.tsx.preview dose not include a break line, but for some reason docs:typescript:formatted throws an error here, I'll run the command locally and it passes fine 🙃

@aarongarciah aarongarciah added component: snackbar This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Jan 24, 2025
@aarongarciah aarongarciah changed the title Add Slots and SlotProps [material-ui][Snackbar] Add Slots and SlotProps Jan 24, 2025
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 24, 2025
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 27, 2025
siriwatknp
siriwatknp approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you so much for your contribution.

I updated some part of the code to use useSlot instead for consistency and updated the tests. The codemod looks good to me.

@harry-whorlow
Copy link
Contributor Author

@siriwatknp Awesome, thanks for the review and update! I suppose it's over to @DiegoAndai then 🤟

@siriwatknp siriwatknp mentioned this pull request Jan 27, 2025
Open
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

@DiegoAndai DiegoAndai Awaiting requested review from DiegoAndai

Assignees
No one assigned
Labels
component: snackbar This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harry-whorlow @mui-bot @siriwatknp @aarongarciah