[test] Remove unnecessary prop type check in test #43211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-43211--material-ui.netlify.app/ Bundle size report |
DiegoAndai
reviewed
Aug 6, 2024
Co-authored-by: Diego Andai <diego@mui.com> Signed-off-by: Aarón García Hervás <aaron.garcia.hervas@gmail.com>
mnajdova
reviewed
Aug 7, 2024
mnajdova
approved these changes
Aug 7, 2024
DiegoAndai
approved these changes
Aug 7, 2024
This reverts commit e139e03.
DiegoAndai
approved these changes
Aug 7, 2024
37 tasks
DiegoAndai
added a commit
to DiegoAndai/material-ui
that referenced
this pull request
Nov 26, 2024
Signed-off-by: Aarón García Hervás <aaron.garcia.hervas@gmail.com> Co-authored-by: Diego Andai <diego@mui.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a prop type check in a test because it's already covered in another test in the same file. We forgot to fix this one in #43155.
Example of the test failure without this fix: https://app.circleci.com/pipelines/github/mui/material-ui/135461/workflows/b151718a-3164-404f-974a-3c13802fca53/jobs/730232?invite=true#step-111-171
Context: React 19 removed prop type checks so we need to skip them in prior versions. More info: https://react.dev/blog/2024/04/25/react-19-upgrade-guide#removed-proptypes-and-defaultprops