[material-ui][FormcontrolLabel] Fix applying slotProps.typography
#42278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewBundle size reportDetails of bundle changes (Toolpad) |
sai6855
commented
May 17, 2024
| @@ -173,7 +173,7 @@ const FormControlLabel = React.forwardRef(function FormControlLabel(inProps, ref | |||
| externalForwardedProps, | |||
| ownerState, | |||
| }); | |||
|
|
|||
| delete typographySlotProps.ownerState; | |||
There was a problem hiding this comment.
In this PR we avoided deleting ownerState and went with fixing spreading of ownerState in Typograpghy for passing slotProps correctly (PR -> #41903 ).
But fixing spreading of ownerState didn't fully fixed passing slotProps issues, as we can still see the issue mentioned in PR description, so i'm again reverting to this approach.
I believe root cause for ownerState issues are tracked here #42184
slotProps.typography correctly
sai6855
commented
May 17, 2024
| @@ -331,4 +331,23 @@ describe('<FormControlLabel />', () => { | |||
|
|
|||
| expect(getByTestId('control')).to.have.attribute('value', 'test'); | |||
| }); | |||
|
|
|||
| it('label should have noWrap styles', function test() { | |||
slotProps.typography correctlyslotProps.typography
|
Not sure about argos issue, i don't think it's related to this PR (even on merging latest next branch, argos issue didn't fixed) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #42277