Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][ListItem] Deprecate ListItem's components and componentsProps #42219

Merged
merged 5 commits into from
May 23, 2024
Merged

[material-ui][ListItem] Deprecate ListItem's components and componentsProps #42219

merged 5 commits into from
May 23, 2024

Conversation

aarongarciah
Copy link
Member

@aarongarciah aarongarciah commented May 13, 2024 •
edited
Loading

Part of: #41279

Deprecate ListItem's components and componentsProps props in favor of slots and slotProps respectively. Includes the corresponding codemod and documentation updates.

@aarongarciah aarongarciah added component: list This is the name of the generic UI component, not the React module! deprecation New deprecation message package: material-ui Specific to @mui/material labels May 13, 2024
@aarongarciah aarongarciah mentioned this pull request May 13, 2024
Closed
17 tasks
@mui-bot
Copy link

mui-bot commented May 13, 2024 •
edited
Loading

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 69d99ed

@aarongarciah aarongarciah marked this pull request as ready for review May 13, 2024 09:36
@aarongarciah aarongarciah requested a review from DiegoAndai May 13, 2024 09:36
@aarongarciah aarongarciah changed the title [material-ui][ListItem] Deprecate ListItem's components and componentsProps [material-ui][ListItem] Deprecate ListItem's components and componentsProps May 13, 2024
@aarongarciah aarongarciah changed the title [material-ui][ListItem] Deprecate ListItem's components and componentsProps [material-ui][ListItem] Deprecate ListItem's components and componentsProps May 13, 2024
DiegoAndai
DiegoAndai reviewed May 14, 2024
View reviewed changes
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @aarongarciah!

I couple of copy corrections but otherwise looks good 😊

docs/data/material/migration/migrating-from-deprecated-apis/migrating-from-deprecated-apis.md Outdated Show resolved Hide resolved
packages/mui-codemod/README.md Outdated Show resolved Hide resolved
packages/mui-material/src/ListItem/ListItem.js Outdated Show resolved Hide resolved
@aarongarciah aarongarciah requested a review from DiegoAndai May 14, 2024 21:30
@aarongarciah aarongarciah force-pushed the aarongarcia/listitem-slot-props branch from d663531 to cba1387 Compare May 15, 2024 06:58
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 20, 2024
DiegoAndai
DiegoAndai approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@aarongarciah aarongarciah force-pushed the aarongarcia/listitem-slot-props branch from cba1387 to 7378ea0 Compare May 23, 2024 18:53
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels May 23, 2024
@aarongarciah aarongarciah force-pushed the aarongarcia/listitem-slot-props branch from 7378ea0 to 3f68b08 Compare May 23, 2024 19:01
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 23, 2024
@aarongarciah aarongarciah reopened this May 23, 2024
@aarongarciah aarongarciah merged commit beb8fc2 into mui:next May 23, 2024
31 checks passed
@aarongarciah aarongarciah deleted the aarongarcia/listitem-slot-props branch May 23, 2024 20:31
joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
@aarongarciah @joserodolfofreitas
[material-ui][ListItem] Deprecate ListItem's components and component…
3a246d9 
…sProps (mui#42219)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiegoAndai DiegoAndai DiegoAndai approved these changes

Assignees
No one assigned
Labels
component: list This is the name of the generic UI component, not the React module! deprecation New deprecation message package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aarongarciah @mui-bot @DiegoAndai