[material-ui][InputBase] Deprecate components and componentProps props for v6 #42093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewBundle size report |
|
I can see that some tests are fallen. Seems like it is in |
17 tasks
|
Hey @ChronicusUA! thanks for working on this one 🚀
We can keep all 4 components in this PR, as the types all come from the same place (
This is a flaky test on our CI, so don't worry about it at the moment 😊 I'll review this one in more detail on Monday |
1f0b1a1 to
08ce047
Compare
… Input Components
08ce047 to
130ca44
Compare
|
PR is updated with the latest changes from next branch |
DiegoAndai
reviewed
May 29, 2024
docs/data/material/migration/migrating-from-deprecated-apis/migrating-from-deprecated-apis.md
Outdated
Show resolved
Hide resolved
docs/data/material/migration/migrating-from-deprecated-apis/migrating-from-deprecated-apis.md
Outdated
Show resolved
Hide resolved
docs/data/material/migration/migrating-from-deprecated-apis/migrating-from-deprecated-apis.md
Outdated
Show resolved
Hide resolved
docs/data/material/migration/migrating-from-deprecated-apis/migrating-from-deprecated-apis.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Diego Andai <diego@mui.com>
Signed-off-by: Diego Andai <diego@mui.com>
DiegoAndai
approved these changes
May 29, 2024
|
Thanks @ChronicusUA! |
joserodolfofreitas
pushed a commit
to joserodolfofreitas/material-ui
that referenced
this pull request
Jul 29, 2024
35 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #41279
Deprecate components and componentsProps props
When I added deprecated for InputBase and after running process commands from there I found out that components for Input, FilledInput and OutlinedInput are updated as well. So here the changes for the all 4. If you need to seprate the PR for 4 others (in this case we will have conflicts for
migrating-from-deprecated-apis.mdandmui-codemod/README.mdfiles after merging 1 by 1) please let me know.It will be great if you run tests for mui-codemod locally on linux/Max machine. I run it on my Windows machine and added some potential fix with line endings. BTW on windows I have some tests are fallen (I didn't change parts related to that tests).