Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][docs] Fix minor spelling error in the "About the lab" page (@ryanhartwig) #42075

Merged
merged 1 commit into from
May 1, 2024
Merged

[material-ui][docs] Fix minor spelling error in the "About the lab" page (@ryanhartwig) #42075

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/data/material/components/about-the-lab/about-the-lab.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

For a component to be ready to move to the core, the following criteria are considered:

- It needs to be **used**. We uses Google Analytics in the documentation (among other metrics) to evaluate the usage of each component. A lab component with low usage either means that it isn't fully working yet, or that there is low demand for it.
- It needs to be **used**. We use Google Analytics in the documentation (among other metrics) to evaluate the usage of each component. A lab component with low usage either means that it isn't fully working yet, or that there is low demand for it.

Check warning on line 11 in docs/data/material/components/about-the-lab/about-the-lab.md

View workflow job for this annotation

GitHub Actions / runner / vale 

[vale] reported by reviewdog 🐶
[Google.We] Try to avoid using first-person plural like 'We'.

Raw Output:
{"message": "[Google.We] Try to avoid using first-person plural like 'We'.", "location": {"path": "docs/data/material/components/about-the-lab/about-the-lab.md", "range": {"start": {"line": 11, "column": 28}}}, "severity": "WARNING"}
- It needs to match the **code quality** of the core components. It doesn't have to be perfect to be part of the core, but the component should be reliable enough that developers can depend on it.
- Each component needs **type definitions**. It is not currently required that a lab component is typed, but it would need to be typed to move to the core.
- Requires good **test coverage**. Some of the lab components don't currently have comprehensive tests.
Expand Down
Loading