-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][Chip] Convert to support CSS extraction #41592
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiegoAndai
added
component: chip
This is the name of the generic UI component, not the React module!
package: material-ui
Specific to @mui/material
labels
Mar 21, 2024
Netlify deploy previewhttps://deploy-preview-41592--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
62 tasks
DiegoAndai
commented
Mar 21, 2024
DiegoAndai
requested review from
brijeshb42 and
siriwatknp
and removed request for
brijeshb42
March 21, 2024 15:19
siriwatknp
reviewed
Mar 22, 2024
17 tasks
Updated recording: Screen.Recording.2024-03-22.at.17.52.02.mov |
siriwatknp
reviewed
Mar 25, 2024
siriwatknp
reviewed
Mar 25, 2024
siriwatknp
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks great!
tejasparkar
pushed a commit
to tejasparkar/material-ui
that referenced
this pull request
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: chip
This is the name of the generic UI component, not the React module!
package: material-ui
Specific to @mui/material
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert Chip component to support CSS extraction.
Screen.Recording.2024-03-21.at.12.01.13.mov