[material-ui][docs] Improve aria-label throughout the Button Group demos #40892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-40892--material-ui.netlify.app/ Bundle size report |
mnajdova
reviewed
Feb 1, 2024
mnajdova
reviewed
Feb 1, 2024
DiegoAndai
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Nice 🙌🏼
Also, we should probably confirm whether it's necessary to add role=group" to these containers; it makes sense to me, and it's what Bootstrap also recommends folks doing. Unlike aria-labels, though, that role attribute feels like something that should come out of the box, as it will always be needed in this Button Group context.
This makes sense, may I ask you to create an issue for tracking this?
|
@DiegoAndai — never mind, I think I skimmed through it too fast and didn't see it, but the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following recent docs-feedback — some aria labels were really not great and could use some basic polish.
https://deploy-preview-40892--material-ui.netlify.app/material-ui/react-button-group/