[zero] Fix build for demo next.js app #40854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-40854--material-ui.netlify.app/ Bundle size report |
brijeshb42
commented
Jan 30, 2024
| @@ -89,6 +89,7 @@ | |||
| "peerDependencies": { | |||
| "@emotion/react": "^11.5.0", | |||
| "@emotion/styled": "^11.3.0", | |||
| "@mui/zero-runtime": "workspace:^", | |||
There was a problem hiding this comment.
Not sure if this is the right approach but I think the current error only affects when used with pnpm.
There was a problem hiding this comment.
I think optional is needed as well?
"peerDependenciesMeta": {
…
"@mui/zero-runtime": {
"optional": true
}
},There was a problem hiding this comment.
npm automatically install none optional peer dependencies https://github.blog/2020-10-13-presenting-v7-0-0-of-the-npm-cli/#user-content-exciting-new-features since v7, leading to #40969. I think Jun was right.
There was a problem hiding this comment.
I did make the changes but seems I ended up pushing to a different branch. Fixing this.
960e2bb to
9c84550
Compare
This requires adding zero runtime as a peer dep of material (at least when using pnpm)
9c84550 to
d32c257
Compare
siriwatknp
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires adding zero runtime as a peer dep of material (at least when using pnpm). Otherwise getting this error -