Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs-infra] Retain velocity animation speed #38470

Merged
merged 1 commit into from
Aug 21, 2023
Merged

[docs-infra] Retain velocity animation speed #38470

merged 1 commit into from
Aug 21, 2023

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Aug 14, 2023 •
edited
Loading

Reopen #38393, resuming the exploration from #38393 (comment). It was merged while the PR was pending for feedback.

Also related to #38164

@oliviertassinari oliviertassinari mentioned this pull request Aug 14, 2023
Merged
@mui-bot
Copy link

mui-bot commented Aug 14, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-38470--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against c1bc227

@oliviertassinari oliviertassinari marked this pull request as ready for review August 20, 2023 22:16
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Aug 20, 2023 •
edited
Loading

@danilo-leal I have tried something, let me know how you feel about it.

On my end, when comparing https://master--material-ui.netlify.app/base-ui/getting-started/customization/ with https://deploy-preview-38470--material-ui.netlify.app/base-ui/getting-started/customization/.
"Getting started" expands faster, which feels better,
"Components" expands slower, which feels more consistent with the other sections, like "Getting started", so also feels better.

@oliviertassinari oliviertassinari added design This is about UI or UX design, please involve a designer scope: docs-infra Specific to the docs-infra product component: accordion This is the name of the generic UI component, not the React module! labels Aug 20, 2023
@zannager zannager requested a review from siriwatknp August 21, 2023 02:55
danilo-leal
danilo-leal approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! 🤙

@oliviertassinari oliviertassinari merged commit 5e638fe into mui:master Aug 21, 2023
@oliviertassinari oliviertassinari deleted the docs-collapse branch August 21, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilo-leal danilo-leal danilo-leal approved these changes

@siriwatknp siriwatknp Awaiting requested review from siriwatknp

Assignees
No one assigned
Labels
component: accordion This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer scope: docs-infra Specific to the docs-infra product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliviertassinari @mui-bot @danilo-leal