[Select] Accept non-component children #33530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
michaldudak
reviewed
Jul 19, 2022
|
Hi @michaldudak, thanks for reviewing the PR in a short time, I appreciate that and I'm sorry for being late, the changes are done! thanks! |
|
Could you please rebase/merge the latest master? This should fix argos. |
…handle-no-react-elements
|
Hi @michaldudak thanks for the review, the changes are addressed! |
michaldudak
reviewed
Aug 8, 2022
| @@ -1,22 +1,22 @@ | |||
| import * as React from 'react'; | |||
| import Divider from '@mui/material/Divider'; | |||
There was a problem hiding this comment.
Please revert the change of import order. It's not related to this PR. We usually import react first, then external packages, and then @mui-scoped package.
mnajdova
reviewed
Dec 16, 2022
Signed-off-by: Marija Najdova <mnajdova@gmail.com>
mnajdova
approved these changes
Dec 16, 2022
There was a problem hiding this comment.
I pushed some cleanup commits to revert the unnecessary changes. The logic & test-case look great. Thanks @boutahlilsoufiane 👌
|
Hi @mnajdova, I appreciate your help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #32253.
This fixes the problem of conditional rendering on the options with
""or passing no React element option to Select component!